Subversion Repositories eduke32

Rev

Go to most recent revision | Show changed files | Directory listing | RSS feed

Filtering Options

Rev Age Author Path Log message Diff
4742 2523d 15h terminx / Add my _clang-format file to the repository. These options are pretty close to what most of our code already looks like, the primary difference being that it enforces spaces between operators and operands. I was initially opposed to the spaces, but I would be lying if I said they didn't increase legibility of much of our code, in addition to making it a lot easier to identify the specific intent in cases where we have a lot of expressions nested within one another. DONT_BUILD.  
4741 2523d 15h terminx / Fix up conveyor belts. This fixes breakage of the movement in general, as well as corrects the general behavior of the effect so that a player on a moving surface is moved at a constant rate, regardless of whether the player crouches, is shrunk, etc. DONT_BUILD.  
4740 2523d 15h terminx / Fix Mapster32 fullscreen video modes. DONT_BUILD.  
4739 2528d 19h hendricks266 / Fix minor menu bugs. DONT_BUILD.  
4738 2528d 20h hendricks266 / Set up mouse cursor display in menus, with idle timeout fully implemented. No functionality yet. DONT_BUILD.  
4737 2538d 5h helixhorned / Fix C++ build. DONT_BUILD.  
4736 2538d 5h helixhorned / In release builds, #define Xaligned_alloc as xaligned_malloc.

Otherwise, the out-of-memory handler is not called in case of failure.
 
4735 2538d 5h helixhorned / C-CON: fix 'readgamearray' and 'resizearray' on Windows.

We must not use Xrealloc(), since gamearrays are now allocated with
Xaligned_alloc().
NOTE: I did not check all potential problematic cases, only those to get
LNGA3 up and running.
 
4734 2538d 5h helixhorned / C-CON: fix 'readgamearray' on 64-bit platforms.

Also prettify P_DisplaySpit().
 
4733 2538d 5h helixhorned / a-c.c: don't USE_VECTOR_EXT with Clang, since it doesn't compile here.  
4732 2538d 5h helixhorned / LunaCON: player[].loogcnt, userdef[].color, minor fixes.  
4731 2538d 5h helixhorned / LunaCON: fix tilesizx[] and tilesizy[] system gamearrays.  
4730 2538d 20h hendricks266 / Replace DOS box-drawing characters in the ASM with sane ASCII. DONT_BUILD.  
4729 2539d 4h helixhorned / Lunatic: some minor doc tweaks. DONT_BUILD.  
4728 2539d 4h helixhorned / Fix voxels in classic -- my error, confusing divscale() and mulscale() in r4576.

Optimizations are left to the reader :P. I would prefer to look for ways of
giving the compilers hints about loops to unroll instead of having to read
the resulting mess of manual unrolling, though.
 
4727 2539d 4h helixhorned / gameexec.c: In VM_OnEvent_, don't form address like &sprite[-1].

The practical rationale: Clang-sanitize catches this, so this is bad.
The real rationale: I *think* it is undefined behavior to even form such a
pointer in C99. However, I would be hard pressed to provide a nice formal
argument in terms of the Standard wording right now. It looks like
6.5.3.2#4 is to blame.
 
4726 2539d 4h helixhorned / engine.c: prevent an oob read in drawsprite_classic() w/ floor-aligned sprites.  
4725 2539d 4h helixhorned / Fix oob write with stepping 'up' in the OSD history.  
4724 2539d 4h helixhorned / baselayer.c: fix an oob write to ylookup[] intoduced in r4695.

On Linux, it started manifesting itself since r4719 as crashes whose
backtraces pointed to malloc() and were not helpful. Valgrind finally
uncovered this.
 
4723 2543d 22h terminx / Useless change I forgot. DONT_BUILD.  

Show All